Skip to content

fixup missed issues from #130 and #137#138

Open
gknapp1 wants to merge 8 commits intomainfrom
fixup-apps
Open

fixup missed issues from #130 and #137#138
gknapp1 wants to merge 8 commits intomainfrom
fixup-apps

Conversation

@gknapp1
Copy link
Collaborator

@gknapp1 gknapp1 commented Feb 11, 2026

Corrects issues:

  • from fixup: correct template dir behavior in base app #130: Some applications had app.copy_template_to_dir() functions that behaved similarly but not exactly the same to the MynaApp.copy_template_to_case() function.
  • from implement ruff for auto-formatting and linting #137: Handling of the FileNotFoundError error possible in MynaApp.copy_template_to_case() if the case directory does not exist. For example, if copying to the myna_resource directory as a temporary location, which some apps do (because myna config creates all case directories before myna run, this is not a common occurrence and is not captured in the current test suite)

@gknapp1 gknapp1 closed this Feb 11, 2026
@gknapp1 gknapp1 reopened this Feb 11, 2026
@gknapp1 gknapp1 changed the title fixup missed issues from #130 fixup missed issues from #130 and #137 Feb 11, 2026
@gknapp1 gknapp1 self-assigned this Feb 11, 2026
@gknapp1 gknapp1 requested a review from streeve February 11, 2026 22:06
Copy link
Collaborator

@streeve streeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably too many things in one PR..

@gknapp1
Copy link
Collaborator Author

gknapp1 commented Feb 13, 2026

Probably too many things in one PR..

Fair, this did turn into more of a "get CI working again with the updated container build" catchall (note that the CI should fail until container repo PR is merged). Separating it out would mean force merging at least one PRs with failing CI...not sure which is the greater git faux pas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants